You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: The hardcoded URL appears to be a development or staging environment. For production code, consider using a configuration variable or environment variable to make the base URL configurable across different environments. [general, importance: 7]
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: The alert message says "Magnet link copied" but you're actually copying a ReplayWeb.page URL. Update the message to accurately reflect what's being copied to avoid user confusion. [general, importance: 8]
Suggested change
// Copy to clipboard
navigator.clipboard
.writeText(magnetURI)
.writeText(replayLink)
.then(()=>{
alert(`Magnet link copied to clipboard:\n${magnetURI}`);
alert(`Magnet link copied to clipboard:\n${replayLink}`);
})
.catch((err)=>{
console.error("Failed to copy magnet link:",err);
alert(`Magnet Link Ready:\n${magnetURI}`);
alert(`Magnet Link Ready:\n${replayLink}`);
});
// Copy to clipboard
navigator.clipboard
.writeText(replayLink)
.then(()=>{
alert(`ReplayWeb.page link copied to clipboard:\n${replayLink}`);
})
.catch((err)=>{
console.error("Failed to copy ReplayWeb.page link:",err);
alert(`ReplayWeb.page Link Ready:\n${replayLink}`);
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
![pr-agent-monadical[bot]](https://avatars.githubusercontent.com/u/29933591?s=60&v=4){kind=small}
User description
Now, Copy Link and the share button copy the ReplayWeb.page URL link instead of a simple magnet url. #18
PR Type
Enhancement
Description
Replace magnet URI with ReplayWeb.page URL
Add REPLAY_BASE_URL constant for link generation
Update copy link functionality in multiple components
Changes walkthrough 📝
argo-shared-archive-list.ts
Update archive list to use ReplayWeb.page URLssrc/argo-shared-archive-list.ts
URI
sidepanel.ts
Update sidepanel to use ReplayWeb.page URLssrc/sidepanel.ts
consts.ts
Add ReplayWeb.page base URL constantsrc/consts.ts
"https://replayweb-page-m-git-nikita-webtorrent-integration-monadical.vercel.app"